ARROW-10089: [R] inject base class for Array, ChunkedArray and Scalar#9345
Closed
nealrichardson wants to merge 6 commits into
Closed
ARROW-10089: [R] inject base class for Array, ChunkedArray and Scalar#9345nealrichardson wants to merge 6 commits into
nealrichardson wants to merge 6 commits into
Conversation
ianmcook
reviewed
Jan 29, 2021
Member
There was a problem hiding this comment.
Could you add a TODO/comment here describing why this has not yet been changed to a method of the base class ArrowTabular? And another one where $<-.Table is defined
Member
Author
There was a problem hiding this comment.
I ended up moving them to ArrowTabular and left stop(TODO) messages in the missing RecordBatch methods.
Member
|
@nealrichardson could you please confirm that this is correct?
|
nealrichardson
force-pushed
the
arrow-datum
branch
from
39ee59d to
879a448
Compare
Member
Author
Correct, and I expanded on the comments about that in the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The impetus for this change was to get S3 Ops method dispatch to work for Array == Scalar. This is tested in the third commit.